Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Uniswap Liquidity Error #225 [WIP] #6731

Open
wants to merge 21 commits into
base: development
Choose a base branch
from

Conversation

mlguys
Copy link
Contributor

@mlguys mlguys commented Dec 21, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Solution for fixing this issue: hummingbot/gateway#225

TODOs:

  • Added solution to prevent creating new position that uses more fund than the available fund
  • Improved handling out of range positions
  • Fixed creating ZERO_LIQUIDITY position
  • Update test cases
  • Fixing instance where transactions to get position info and collect fees got rejected
  • Refactor check if position in range logic

Tests performed by the developer:

  • Run uniswap_v3_lp strategy on ARB-USDC.e pair on Arbitrum for several hours

Tips for QA testing:

- Improved handling out of range positions
- Fixed creating ZERO_LIQUIDITY position
@mlguys
Copy link
Contributor Author

mlguys commented Dec 21, 2023

Updated todos in PR description.

@mlguys mlguys changed the title Fix/Uniswap Liquidity Error #225 Fix/Uniswap Liquidity Error #225 [WIP] Dec 21, 2023
- Refactor logic for checking if price is in range
- Increase poll interval to prevent rejection from rcp node
- New "buffer_spread" config to keep position active when price goes out of range and not matured yet
@rapcmia rapcmia requested review from rapcmia and nikspz January 5, 2024 14:02
@nikspz
Copy link
Contributor

nikspz commented Feb 13, 2024

@mlguys
Copy link
Contributor Author

mlguys commented Feb 14, 2024

Hey @nikspz will do by the weekend, I need to add some more updates to finalize the solution too.

@nikspz
Copy link
Contributor

nikspz commented Feb 27, 2024

@mlguys Could you please add test coverage on this PR here when you have time?
https://github.com/hummingbot/hummingbot/actions/runs/8068196861/job/22040391549?pr=6731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Dev Work
Development

Successfully merging this pull request may close these issues.

None yet

3 participants