New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/simplify starter scripts #7011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- simple_pmm
- Setup with Kraken and spreads enough for trade event ok
- simple_xemm
- Setup with Kraken and Binance
- Setup with two paper trade connectors ok
- v2_generic_with_controllers
- Setup with binance perp
- directional_trading.bollinger_v1
- market_making.dman_maker
- Setup with binance perp
Pending:
- simple_rsi
- simple_vwap
simple_vwap: ok commit 8033e91 Steps:
Actual: |
@fengtality issue with config creation fixed ✔ simple_rsi Client not created order to Steps to reproduce:
Actual:
|
Thanks @nikspz. I think that simple_rsi script is outdated. I decided to use the V2 directional script instead, which should fix the issues you saw. I also moved the other V2 scripts into the base scripts folder but I don't think you need to re-test them. |
logs_conf_v2_simple_directional_rsi_1.log
|
@nikspz The library import issue should be fixed now |
@nikspz I'd like to merge this in so we can wrap up the Vega video |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- simple_pmm: ok
- simple_xemm: ok
- Setup with Kraken and Binance
- Setup with two paper trade connectors ok
- v2_with_controllers: ok
- simple_vwap: ok
- v2_directional_rsi: ok
This PR cleans up the
/scripts
directory and basic script examples. Now, there are only 5 scripts that are inscripts
:All the simple scripts accept config files.
Other scripts are located in sub-folders in the main
scripts
directory, no longer nested in/achived-scripts
.Instructions for QA