New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/hyperliquid_recreates_reversing_order_on_close #7013
fix/hyperliquid_recreates_reversing_order_on_close #7013
Conversation
commit 8dfc7f0 Test performed:
Pending: ongoing longrun |
@yancong001 could you add tests to this one? |
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test performed:
- Cloned PR7013
- Set up dmanv3 controller using hyperliquid and config from Hyperliquid recreates reversing order on close #6948
- no errors showed during the run
- Review issue not reproduced during ~3 days
#7024 |
The problem has been solved #7027 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @yancong001
I've been testing this and noticed the same as nikspz. Now the script isn't working on Hyperliquid. The logs are attached. If you need more info just let me know. |
The issue was fixed at #7027 |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing: