Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/hyperliquid_recreates_reversing_order_on_close #7013

Conversation

yancong001
Copy link
Contributor

@yancong001 yancong001 commented May 6, 2024

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

Tests performed by the developer:

Tips for QA testing:

@rapcmia rapcmia requested review from cardosofede and nikspz May 7, 2024 09:30
@nikspz
Copy link
Contributor

nikspz commented May 7, 2024

commit 8dfc7f0

Test performed:

Pending: ongoing longrun

image

@nikspz
Copy link
Contributor

nikspz commented May 9, 2024

@yancong001 could you add tests to this one?

@yancong001
Copy link
Contributor Author

added

Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

@nikspz
Copy link
Contributor

nikspz commented May 13, 2024

#7024
Reproduced on this PR as well
@yancong001 could you have a look?

@yancong001
Copy link
Contributor Author

yancong001 commented May 14, 2024

The problem has been solved #7027

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @yancong001

@cardosofede cardosofede merged commit ab69594 into hummingbot:development May 14, 2024
2 checks passed
@tijsk
Copy link

tijsk commented May 16, 2024

I've been testing this and noticed the same as nikspz. Now the script isn't working on Hyperliquid.
Last week I was able to place order, but they reversed again after a while. Now the orders aren't submitted to Hyperliquid (no data in "Order history")

The logs are attached. If you need more info just let me know.
logs_conf_v2_generic_with_controllers_HL-dman.log

@yancong001
Copy link
Contributor Author

I've been testing this and noticed the same as nikspz. Now the script isn't working on Hyperliquid. Last week I was able to place order, but they reversed again after a while. Now the orders aren't submitted to Hyperliquid (no data in "Order history")

The logs are attached. If you need more info just let me know. logs_conf_v2_generic_with_controllers_HL-dman.log

The issue was fixed at #7027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development 1.28.0
Development

Successfully merging this pull request may close these issues.

None yet

4 participants