Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix / Support latest PolkaDEX API #7016

Merged

Conversation

dizpers
Copy link

@dizpers dizpers commented May 7, 2024

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

PolkaDEX team had updated their APIs (with breaking changes), so the connector in public version of Hummingbot became broken. This PR made all the fixes needed for this connector to work properly and also include some improvements (like result pagination).

The test suite still need to be updated, so I'm disabling it for now.

Tests performed by the developer:

  1. Manually tested in local environment (following HF checklist)
  2. Bots are successfully running in production environment.

Tips for QA testing:

N/A

@nikspz nikspz changed the base branch from master to development May 7, 2024 16:44
@nikspz
Copy link
Contributor

nikspz commented May 7, 2024

@dizpers thank you for submitting PR, fyi, it should be aimed to development, I changed it for now https://hummingbot.org/developers/contributions/#checklist

@rapcmia
Copy link
Contributor

rapcmia commented May 8, 2024

Hi @dizpers good day
Can you take a look on the branch conflicts? thanks

@dizpers
Copy link
Author

dizpers commented May 8, 2024

@nikspz @rapcmia Thanks for initial checks, working on conflicts resolution now.

@dizpers dizpers closed this May 8, 2024
@dizpers dizpers force-pushed the fix/polkadex-support-latest-api branch from 1bd88af to 7e1de3e Compare May 8, 2024 07:24
@dizpers dizpers reopened this May 8, 2024
@dizpers
Copy link
Author

dizpers commented May 8, 2024

@dizpers
Copy link
Author

dizpers commented May 8, 2024

@rapcmia @nikspz conflicts are resolved now

@dizpers
Copy link
Author

dizpers commented May 8, 2024

Looks like it requires tests to be fixed as well

Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Ran tests on source build local macos
  • Create new account and use for setting up the connector, all ok
  • Balance displayed ok
  • Using v1 strategy (pmm)
    • Orders are created, fetched and cancelled successfully
    • Trade orders are recorded matched between history, CSV and exchange trade history
    • Run for couple of hours with low and high refresh time ok
  • Build docker image ok

Copy link

1 similar comment
Copy link

@dizpers
Copy link
Author

dizpers commented May 8, 2024

@rapcmia All PolkaDEX tests has been fixed. So I'm enabling them back in Makefile and in coverage configuration.

@Gauthamastro
Copy link

Hey guys, is there anything blocking this to be merged? Can we help somehow to merge this sooner?

@nikspz
Copy link
Contributor

nikspz commented May 14, 2024

@dizpers
Copy link
Author

dizpers commented May 14, 2024

@Gauthamastro @nikspz yes, Enflux team is working on that now.

@dizpers
Copy link
Author

dizpers commented May 14, 2024

@rapcmia @nikspz coverage should be 80%+ now, could your run the workflow?

@rapcmia
Copy link
Contributor

rapcmia commented May 15, 2024

Hi @dizpers thanks for the update, the github checks are failing on some tests below:
image

Copy link

@dizpers
Copy link
Author

dizpers commented May 15, 2024

@rapcmia @nikspz could you run the pipeline one more time?

Copy link
Contributor

@cardosofede cardosofede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -76,8 +80,8 @@
),
RateLimit(
limit_id=PLACE_ORDER_LIMIT_ID,
limit=NO_LIMIT,
time_interval=SECOND,
limit=2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only supports 2 orders every 2 secs?

@rapcmia rapcmia merged commit 65c4b82 into hummingbot:development May 16, 2024
2 checks passed
@rapcmia
Copy link
Contributor

rapcmia commented May 16, 2024

Merged to development and part of release version 1.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development 1.28.0
Development

Successfully merging this pull request may close these issues.

None yet

5 participants