New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix / Support latest PolkaDEX API #7016
fix / Support latest PolkaDEX API #7016
Conversation
@dizpers thank you for submitting PR, fyi, it should be aimed to development, I changed it for now https://hummingbot.org/developers/contributions/#checklist |
Hi @dizpers good day |
1bd88af
to
7e1de3e
Compare
Looks like it requires tests to be fixed as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Ran tests on source build local macos
- Create new account and use for setting up the connector, all ok
- Balance displayed ok
- Using v1 strategy (pmm)
- Orders are created, fetched and cancelled successfully
- Trade orders are recorded matched between history, CSV and exchange trade history
- Run for couple of hours with low and high refresh time ok
- Build docker image ok
1 similar comment
@rapcmia All PolkaDEX tests has been fixed. So I'm enabling them back in Makefile and in coverage configuration. |
Hey guys, is there anything blocking this to be merged? Can we help somehow to merge this sooner? |
hi @Gauthamastro Yes, we need to add test coverage here @dizpers |
@Gauthamastro @nikspz yes, Enflux team is working on that now. |
Hi @dizpers thanks for the update, the github checks are failing on some tests below: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -76,8 +80,8 @@ | |||
), | |||
RateLimit( | |||
limit_id=PLACE_ORDER_LIMIT_ID, | |||
limit=NO_LIMIT, | |||
time_interval=SECOND, | |||
limit=2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only supports 2 orders every 2 secs?
Merged to development and part of release version 1.28.0 |
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
PolkaDEX team had updated their APIs (with breaking changes), so the connector in public version of Hummingbot became broken. This PR made all the fixes needed for this connector to work properly and also include some improvements (like result pagination).
The test suite still need to be updated, so I'm disabling it for now.
Tests performed by the developer:
Tips for QA testing:
N/A