Feat/pool id in amm arb

[vic-en]

Before submitting this PR, please make sure:

• Your code builds clean without any errors or warnings
• You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Adds pool_id to amm_arb strategy.
To be tested with hummingbot/gateway#280

Tests performed by the developer:

• Manual test with Gateway

Tips for QA testing:

• Test with feat/ balancer connector gateway#280

[nikspz]

@vic-en Should it be optional?

[fengtality]

See comment below. I think users should be able to enter either trading pair or poolID, and the poolID is used if it is present.

[fengtality]

Change to prompt_on_new=False

I think users should not need to enter a poolID. However, if they do enter a poolID, it should be used instead of the trading pair.

[vic-en]

Noted.

[vic-en]

@fengtality @nikspz This is done

[notion-workspace]

Feat/pool id in amm arb #7018

[fengtality]

thanks @vic-en

@nikspz please test with Balancer and Uniswap on Arbitrum:

Expected behavior:

• User can get price and execute swaps using poolId on Balancer
• User can get price and execute swaps using poolId on Uniswap
• User can get price and execute swaps using trading pair with no poolId on Uniswap

If these cases pass, this PR should be ready to merge

[vic-en]

thanks @vic-en

@nikspz please test with Balancer and Uniswap on Arbitrum:

Expected behavior:

* User can get price and execute swaps using `poolId` on Balancer

* User can get price and execute swaps using `poolId` on Uniswap

* User can get price and execute swaps using trading pair with no `poolId` on Uniswap

If these cases pass, this PR should be ready to merge

@fengtality Uniswap on Gateway wouldn't acknowledge the poolId. Only Balancer will ack it. Core files for all other connectors will need to modified to make use of poolId when it's supplied. Otherwise, they'll always default to using their smart routers.

[vic-en]

That being said, I can update Uniswap to acknowledge the poolId when it's present in my Balancer pr on Gateway this weekend.
It's not a big deal for me.
Other connectors will be left as it.

[vic-en]

@fengtality Let me know if you want me to deprecate the useRouter on Uniswap. It's almost a duplicate feature

[vic-en]

@nikspz @fengtality
Update has been made on Gateway balancer pr on Uniswap to make it acknowledge poolId - hummingbot/gateway@00ec985

[fengtality]

thanks for adding poolId to Uniswap, @vic-en!

I'll review the useRouter status and get back to you soon

[nikspz]

Test performed:

• Cloned and installed PR7018 + gwPR280 ✅

• Failed to get price using poolId on Balancer using 0x848a7ff84cf73d2534c3dac6ab381e177a1cff24 address ❌
  

• Changed poolId to 0x848a7ff84cf73d2534c3dac6ab381e177a1cff240001000000000000000004bb

• Able to get price using poolId on Balancer using 0x848a7ff84cf73d2534c3dac6ab381e177a1cff240001000000000000000004bb address ✅

• Failed to execute swap using amm_arb strategy ❌ (0x848a7ff84cf73d2534c3dac6ab381e177a1cff240001000000000000000004bb pool)
  
  
  
  https://arbiscan.io/address/0x08940dc9B5a19FAb9319b77C61DDA7B8067E6843
  Fail with error 'BAL#507'

• Manually executed BUY with curl successfully ✅

  • https://arbiscan.io/tx/0x0af437418c987da4065ce7ec1295f7d5b4771d92b315b5e42afaf5abfc25d3f6

• second tx to sell failed ❌
  https://arbiscan.io/tx/0xe6f5d7789038b5481130157fc5df524fb71baaf1cc0b09c7015365c83f95825c

• approved in Client, WETH and USDC, ✅
  https://arbiscan.io/tx/0x2035115874025f3ce3800aa0fb5329f8ce63ab78f243244ec72322003cea92ed
  https://arbiscan.io/tx/0xc269fc7b3d9a2b92eec29d0bf6ded90e93f5bb4764a354d89989a2acc91274be

• tried sell request on curl again, failed ❌
  https://arbiscan.io/tx/0x0a6d3f2a019b78512c20ae5cb0d1efeed0e1700b5e38f8f34ea0e407a95b747d

[vic-en]

@nikspz Seems only sells failed. I'll get back soon.

[vic-en]

@nikspz Balancer pool ids are the longer addresses. That is why they worked.