New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) add okx spot candles + tests #7022
(feat) add okx spot candles + tests #7022
Conversation
@nikspz now it's ready to test, i've added more tests and fix okx perpetual candle feed note: i've updated the script to perform qa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Test performed:
@tomasgaudino Volume and quote volume is the same for Okx Spot Steps:
|
@nikspz done, there was a minor error parsing the api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Tests performed:
- Cloned and installed PR7022
- started/edited script provided by tomasgaudino
- Review that candles matched for
- 1m
- 5m
- 15m
- 1h
- 4h
- 1d
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing: