New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: switch toString w/ toLocaleString to be able to format numbers in formatDiff #269

Open

moaali wants to merge 1 commit into hustcc:master from moaali:to-locale-string-fix

moaali commented Mar 18, 2024

This PR fixes the issue of displaying numbers in english all the time regardless of the selected locale by adding numberLocale option

Issue was: منذ 3 دقائق showing english number in arabic

With this PR you can do this:

render(node, 'ar', { numberLocale: 'ar-u-nu-arab' })

and it takes the correct form: منذ ٣ دقائق


          fix: switch toString w/ toLocaleString to be able to format numbers i…

d6d93de

…n languages other than english

cr-gpt bot commented Mar 18, 2024

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment