Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Read The Docs, Azure Pipelines, Command Line Run via Click, Add use of Linting and Testing via Docker #10

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

timgates42
Copy link

No description provided.

@timgates42 timgates42 changed the title Add support for ReadTheDocs Add support for Read The Docs, Azure Pipelines, Command Line Run via Click, Add use of Linting and Testing via Docker Jul 25, 2019
@timgates42
Copy link
Author

I was actually intending to merge this change to my fork but if you are interested in my extensions to PRTG going back to this repository then please let me know - happy to discuss any changes you would like to see. I'm also happy just continuing to maintain my fork so I won't be upset if its too much change.

@hutchris
Copy link
Owner

Hey Tim

Sorry I took so long to respond. I was trying to figure out whether I wanted all the additional complexity that comes along with the awesome work you've done to modernize this repo. I think because I don't have much time to maintain this at the moment, I will be fine with adding these changes.

How will it work once I merge the pull request? Would you like to be a maintainer of this repo, or continue your own fork and occasionally merge features?

@timgates42
Copy link
Author

Thanks for responding @hutchris I am happy to setup an organization, I'll add you as an admin of this organization and we could transfer the repository to the organization that way we can both maintain it as needed. Does this sound like a good idea? The alternative I've sometimes seen done is to grant me access to the repository in your account so I can maintain it there. I think the organization way is nicer, but its totally up to you. I'll set one up as its pretty straight forward and if you aren't happy then its no problem.

@timgates42
Copy link
Author

I've invited you https://github.com/prtg-dev if you want to accept. Thanks.

@hutchris
Copy link
Owner

Sounds good. Will do some research about how this works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants