Transform assembly signing attributes #258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transform assembly sign attributes
mungojam
requested changes
Aug 17, 2019
There was a problem hiding this comment.
Just the one change that I don't believe is required. Otherwise I would be happy to accept this in. I did similar in a custom transform but I didn't want to assume that people would want all of the assembly properties brought into the project file. It's good that you do too though :)
| @@ -121,7 +136,7 @@ public string GetAttribute(Type attributeType) | |||
|
|
|||
| //Make the assumption that it just has a single string argument | |||
| //because all of the attributes we currently look for do have | |||
| return att?.ArgumentList.Arguments.Single().ToString().Trim('"'); | |||
| return att?.ArgumentList.Arguments.Single().ToString().TrimStart('@').Trim('"'); | |||
There was a problem hiding this comment.
I don't believe this change will achieve anything. The @ at the start e.g. @"c:\something" is just for reading the typed string, the resultant string in memory will be the same as if somebody had escaped slashes directly "c:\\something".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Siging of an assembly can also be done using assembly attributes in the assemblyinfo.cs
[assembly: AssemblyDelaySign(true)]
[assembly: AssemblyKeyFile(@"....\PublicKey.snk")]
With this pull request these attributes get also transformed