Fix custom HTTP client documentation #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge v0.2.2 into master
Merge v0.2.3 into main
Previous documentation suggested using `axios` which does not support the Fetch API
|
That's technically correct, but it is still possible to swap in |
|
As far as I'm aware a Fetch-like API is planned for axios but hasn't launched yet [0][1]. I'd be very surprised if substituting axios directly like this works as it uses [0] axios/axios#4209 |
|
Yup you're right, I think I hadn't re-compiled the TS to JS when I tested it with JS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just seen the updated documentation suggested using
axiosas an alternative fetch instance which does not support the Fetch API. I've changed this to use anode-fetchexample instead.