Allow setting session namespace and prefix #1060
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApacheEx
requested changes
May 29, 2019
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function clear() | ||
| { | ||
| $_SESSION[$this->storeNamespace] = []; | ||
| if (!$this->storeNamespace) { | ||
| $_SESSION = []; |
There was a problem hiding this comment.
not sure if it's safe .... need to find out another way
There was a problem hiding this comment.
I agree. But without namespace, this is probably only an easy way. Another way may be to manually unset all keys that are set by HybridAuth.
There was a problem hiding this comment.
@filips123 how about this:
we make storeNamespace as required param - So, then we are safe.
There was a problem hiding this comment.
@ApacheEx Ok, I will fix this tomorrow.
|
Hi there guys! Are you still planning to merge this PR with the master and add it to the released version? Let me know, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for setting session namespace and prefix.