Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider for OpenStreetMap, using OAuth 1.0a, for v3 #1094

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

don-vip
Copy link

@don-vip don-vip commented Jun 24, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change? No
Minor: New Feature? Yes (for v3)

This PR re-adds the OpenStreetMap (OSM) provider that was added in v2 (#869) but was not ported to v3 yet.

I cherry-picked the old commits to preserve history and credit @jocelynj work instead of a copy/paste.

@jocelynj
Copy link
Contributor

@don-vip: you don't really need to keep my commits, but thanks anyway :)

@StorytellerCZ StorytellerCZ added this to the 3.x milestone Aug 3, 2019
Copy link
Member

@ApacheEx ApacheEx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you apply this remark and check if everything still works?

src/Provider/OpenStreetMap.php Outdated Show resolved Hide resolved
Copy link
Member

@ApacheEx ApacheEx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you a lot. Would be nice to check this one thing

@ApacheEx ApacheEx modified the milestones: 3.x, 3.3 Mar 4, 2020
@ApacheEx ApacheEx modified the milestones: 3.3, 3.4 Apr 16, 2020
@ApacheEx ApacheEx modified the milestones: 3.4, 3.5 Jul 21, 2020
@ApacheEx ApacheEx modified the milestones: 3.5, 3.x Sep 3, 2020
@alexanderzatko
Copy link

sorry, I did not notice this and created a Provider for OpenStreetMap in my own PR. That one is for OAuth 2 and was tested with the 3.11.0 version of hybridauth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants