PSR-7 support #1099
Open
PSR-7 support #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that this is a breaking change, then this will be for HybridAuth v4.0 |
|
Zend framework is |
|
@zorn-v migrating to laminas seems to be an great idea! |
# Conflicts: # composer.json # src/Adapter/AdapterInterface.php # src/Adapter/OAuth1.php # src/Adapter/OAuth2.php # src/Adapter/OpenID.php # src/Provider/PaypalOpenID.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Changed signature of
Hybridauth\Adapter\AdapterInterface::authenticateso it accepts aPsr\Http\Message\ServerRequestInterface $request = null.Description:
Changed adapters (OpenID, OAuth1, OAuth2) accordingly to new method signature.
If a
$request !== nullis passed toHybridauth\Adapter\AdapterInterface::authenticateit will return a RedirectResponse which can than be handled separately.Allows easy integration into all PSR-15 applications.
Also solves a bug when using custom session handlers like
zendframework/zend-expressive-sessionorpsr7-sessions/storagelesswhere sessions are persisted at the end of the execution chain (which is after::authenticateBeginis called where a redirect is forced).