Line provider #997
Open
Line provider #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
LGTM |
miled
requested changes
Sep 26, 2018
| @@ -16,7 +16,8 @@ | |||
| "gitter": "https://gitter.im/hybridauth/hybridauth" | |||
| }, | |||
| "require": { | |||
| "php": ">=5.4.0" | |||
| "php": ">=5.4.0", | |||
| "firebase/php-jwt": "^5.0" | |||
There was a problem hiding this comment.
Not fan of unnecessary dependencies. Ideally JWT::decode would be contained in the adapter.
There was a problem hiding this comment.
I created nitipatl#1 where JWT is moved to third-party packages of Hybridauth.
Is this OK. I think it is because JWT will maybe be also used by other packages in the future.
So, @nitipatl should merge that PR, so it will be added to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you have any suggest?