Ensure NEXT_DYNAMIC_NO_SSR_CODE has a unique name (vercel#50219)

## What? Ensures `NEXT_DYNAMIC_NO_SSR_CODE` has a unique error code value, this accidentally had the value for dynamic server usage (e.g. calling cookies()) which caused the warning to be shown as shown in vercel#48442. ## How? Changed the digest value to something unique. Fixes NEXT-1125 Fixes vercel#48442
hydRAnger · Jun 12, 2023 · 47d8f7d · 47d8f7d
1 parent 0778892
commit 47d8f7d
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 1 deletion.
diff --git a/packages/next/src/shared/lib/lazy-dynamic/no-ssr-error.ts b/packages/next/src/shared/lib/lazy-dynamic/no-ssr-error.ts
@@ -1,3 +1,3 @@
 // This has to be a shared module which is shared between client component error boundary and dynamic component
 
-export const NEXT_DYNAMIC_NO_SSR_CODE = 'DYNAMIC_SERVER_USAGE'
+export const NEXT_DYNAMIC_NO_SSR_CODE = 'NEXT_DYNAMIC_NO_SSR_CODE'
diff --git a/test/e2e/app-dir/deopted-into-client-rendering-warning/app/layout.tsx b/test/e2e/app-dir/deopted-into-client-rendering-warning/app/layout.tsx
@@ -0,0 +1,7 @@
+export default function Root({ children }: { children: React.ReactNode }) {
+  return (
+    <html>
+      <body>{children}</body>
+    </html>
+  )
+}
diff --git a/test/e2e/app-dir/deopted-into-client-rendering-warning/app/page.tsx b/test/e2e/app-dir/deopted-into-client-rendering-warning/app/page.tsx
@@ -0,0 +1,5 @@
+import { cookies } from 'next/headers'
+export default function Home() {
+  cookies()
+  return null
+}
diff --git a/...p-dir/deopted-into-client-rendering-warning/deopted-into-client-rendering-warning.test.ts b/...p-dir/deopted-into-client-rendering-warning/deopted-into-client-rendering-warning.test.ts
@@ -0,0 +1,12 @@
+import { nextBuild } from 'next-test-utils'
+
+it('should not show deopted into client rendering warning', async () => {
+  const output = await nextBuild(__dirname, undefined, {
+    stdout: true,
+    stderr: true,
+  })
+  expect(output.code).toBe(0)
+  expect(output.stderr).not.toContain(
+    `Entire page / deopted into client-side rendering.`
+  )
+})
diff --git a/test/e2e/app-dir/deopted-into-client-rendering-warning/next.config.js b/test/e2e/app-dir/deopted-into-client-rendering-warning/next.config.js
@@ -0,0 +1,10 @@
+/**
+ * @type {import('next').NextConfig}
+ */
+const nextConfig = {
+  typescript: {
+    ignoreBuildErrors: true,
+  },
+}
+
+module.exports = nextConfig