Skip to content

Commit

Permalink
disable test case for Turbopack (vercel#50530)
Browse files Browse the repository at this point in the history
### What?

This test case was never passing and accidentally enabled for Turbopack.

We could disable the whole test suite, but since only one test case is
affected we can also disable only that one.
  • Loading branch information
sokra authored and hydRAnger committed Jun 12, 2023
1 parent d3b6979 commit d57eeee
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/e2e/app-dir/rsc-basic/rsc-basic.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ createNextDescribe(
'server-only': 'latest',
},
},
({ next, isNextDev, isNextStart }) => {
if (isNextDev) {
({ next, isNextDev, isNextStart, isTurbopack }) => {
if (isNextDev && !isTurbopack) {
it('should have correct client references keys in manifest', async () => {
await next.render('/')
await check(async () => {
Expand Down
8 changes: 8 additions & 0 deletions test/lib/e2e-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ export function createNextDescribe(
isNextDev: boolean
isNextDeploy: boolean
isNextStart: boolean
isTurbopack: boolean
next: NextInstance
}) => void
): void {
Expand Down Expand Up @@ -243,6 +244,13 @@ export function createNextDescribe(
get isNextDev(): boolean {
return Boolean((global as any).isNextDev)
},
get isTurbopack(): boolean {
return Boolean(
(global as any).isNextDev &&
!process.env.TEST_WASM &&
(options.turbo ?? shouldRunTurboDevTest())
)
},

get isNextDeploy(): boolean {
return Boolean((global as any).isNextDeploy)
Expand Down

0 comments on commit d57eeee

Please sign in to comment.