-
Notifications
You must be signed in to change notification settings - Fork 1.8k
WIP: multiple widgets #3142
base: master
Are you sure you want to change the base?
WIP: multiple widgets #3142
Conversation
WIP: still need to limit pipeline and cloud down. there was a lot of `if` conditions there that need examining.
Although this is green bar, I think the sync dashboard will be broken as it assumes the widget name is the type.
in addition to the componentId. This should remove the find first for each build widget and allow each widget to find their own job.
starting with a test. Unfortunately nothing pre-existing, so I'll just add the data how I think it should work.
note this doesn't yet clean up the widget config on edit. I think this will need to happen or else we'll leak widget items.
link by active widget name. Also add type to the widget config so we can track type just in the widget
…gets of the same type Also attempt some ui tests...
takes the hit of the separation of the core into a new project
this is a bit brittle, but will do for now.
ideally we'd allow this - Think I'll need to change the template creation to make the widgets in the template `active`
I am looking for feedback on this from the community as well. It seems the ability to have multiple widgets would increase the flexibility of the dashboards, but I need community help to get this over the line. After this I have plans to start to re-work the layout so we can use the gridstack layout and store that layout info in the ActiveWidget object, and start to allow people to edit the display names for the widget on the title, but I'd like some indication if this is a direction that we'd like to move towards. |
Github Repo Widget /hygieia-scm-github-collector/
|
Is this done? |
There is a reported bug that I've not yet had a chance to reproduce, so could do with some help to confirm what works and what doesn't. I'm also unsure of if the Hygiene team would accept this PR. (Note this needs an API change to be run along side this change for it to work!) @rvema may be able to comment further |
As I see, existing method for Widget information (rather identification and association) is based on Dashboard and Widget Name (may be login id also). This is what appear to be stored in Database for the Widget. Each Widget should be identified as per Login ID, Dashboard ID, Dashboard Tab ID, Widget Name and Widget number / ID (relative within Dashboard). Just like Widget-title, one can provide Widget-Id as one of the attribute for Widget. Appreciate any guidance / pointers to modify old UI to address this requirement of multiple widgets of same type / name. Btw. One team may have just one integrated Team Build but will be distributed across various Jobs of Jenkins. This is exactly current Build Widget lacks. Yes, I may need to switch to Pipeline view but not sure how this works in other CI like Bamboo. Also, they may use more than one repository for integrated team build. |
Note I've not yet re-validated this against the new repo. This is in progress, but I wanted to get some early feedback on this.