Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

WIP: multiple widgets #3142

Open
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

stevegal
Copy link
Contributor

@stevegal stevegal commented Sep 11, 2019

Note I've not yet re-validated this against the new repo. This is in progress, but I wanted to get some early feedback on this.

WIP: still need to limit pipeline and cloud down. there was a lot of `if`
conditions there that need examining.
Although this is green bar, I think the sync dashboard will be broken as it
assumes the widget name is the type.
in addition to the componentId. This should remove the find first for each build widget
and allow each widget to find their own job.
starting with a test. Unfortunately nothing pre-existing, so I'll
just add the data how I think it should work.
note this doesn't yet clean up the widget config on edit. I think this
will need to happen or else we'll leak widget items.
link by active widget name. Also add type to the widget config so
we can track type just in the widget
…gets of the same type

Also attempt some ui tests...
takes the hit of the separation of the core into a new project
this is a bit brittle, but will do for now.
@stevegal stevegal changed the title WIP: Feature/multiple widgets WIP: multiple widgets Sep 11, 2019
@stevegal
Copy link
Contributor Author

I am looking for feedback on this from the community as well. It seems the ability to have multiple widgets would increase the flexibility of the dashboards, but I need community help to get this over the line.

After this I have plans to start to re-work the layout so we can use the gridstack layout and store that layout info in the ActiveWidget object, and start to allow people to edit the display names for the widget on the title, but I'd like some indication if this is a direction that we'd like to move towards.

@HTAfonso
Copy link

@rvema @stevegal

Github Repo Widget /hygieia-scm-github-collector/

  1. UI allow us to add more than 1 repo widget
    2.The same repo tested through the stable version of Hygieia and works fine. This eliminates configuration issues.
  2. when the collector works for the first time the collected data as below
  • Repo Count 3 433s
    2019-12-18 21:46:13,730 [taskScheduler-1] INFO c.c.d.collector.CollectorTask - New Commits 1 433s
    2019-12-18 21:46:13,731 [taskScheduler-1] INFO c.c.d.collector.CollectorTask - New Pulls 449 433s
    2019-12-18 21:46:13,731 [taskScheduler-1] INFO c.c.d.collector.CollectorTask - New Issues 0 433s
    2019-12-18 21:46:13,731 [taskScheduler-1] INFO c.c.d.collector.CollectorTask - Finished 433s
  1. The latest records number of the DB
    db.gitrequests.count() 474
    db.commits.count() 2
    RESULT: according to our test collector seems working fine and collecting the data and DB records sare consistent with collector but UI shows no data. Please let me know if you need more data for troubleshooting

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2020

CLA assistant check
All committers have signed the CLA.

@VivekBuzruk
Copy link

Is this done?

@stevegal
Copy link
Contributor Author

stevegal commented Sep 24, 2020

There is a reported bug that I've not yet had a chance to reproduce, so could do with some help to confirm what works and what doesn't. I'm also unsure of if the Hygiene team would accept this PR. (Note this needs an API change to be run along side this change for it to work!)

@rvema may be able to comment further

@VivekBuzruk
Copy link

VivekBuzruk commented Sep 24, 2020

As I see, existing method for Widget information (rather identification and association) is based on Dashboard and Widget Name (may be login id also). This is what appear to be stored in Database for the Widget.

Each Widget should be identified as per Login ID, Dashboard ID, Dashboard Tab ID, Widget Name and Widget number / ID (relative within Dashboard). Just like Widget-title, one can provide Widget-Id as one of the attribute for Widget.

Appreciate any guidance / pointers to modify old UI to address this requirement of multiple widgets of same type / name.

Btw. One team may have just one integrated Team Build but will be distributed across various Jobs of Jenkins. This is exactly current Build Widget lacks. Yes, I may need to switch to Pipeline view but not sure how this works in other CI like Bamboo. Also, they may use more than one repository for integrated team build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants