Allow the peer delivery client to select policy #4856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semil
force-pushed
the
issue-4847
branch
2 times, most recently
from
b7416c0
to
aebff31
Compare
…Delivere Signed-off-by: Emil Elizarov <emil.elizarov@ibm.com>
tock-ibm
reviewed
May 23, 2024
There was a problem hiding this comment.
Looks good overall. Just a few minor comments.
We'll need to add an integration test that checks that this indeed works (another PR). We can use the same approach is in the orderer.ReplicationPolicy: copy a simple test from the smartbft test suite (that uses a peer) and simply change to Policy="simple".
| @@ -52,6 +54,7 @@ type DeliverServiceConfig struct { | |||
| // OrdererEndpointOverrides is a map of orderer addresses which should be | |||
| // re-mapped to a different orderer endpoint. | |||
| OrdererEndpointOverrides map[string]*orderers.Endpoint | |||
| Policy string | |||
There was a problem hiding this comment.
Add comment with an explanation, same as in the yaml file.
| case "BFT": | ||
| d.blockDeliverer, err = d.createBlockDelivererBFT(chainID, ledgerInfo) | ||
| switch d.conf.DeliverServiceConfig.Policy { | ||
| case "cluster", "": |
There was a problem hiding this comment.
at this stage the policy should not be "", as we det the default "cluster" much earlier.
Comment on lines
+147
to
+149
| if createCftDeliverer { | ||
| d.blockDeliverer, err = d.createBlockDelivererCFT(chainID, ledgerInfo) | ||
| } |
There was a problem hiding this comment.
why not simply call this function from 2 places? it will save 4 line of code, no? (and would be more readable in my opinion).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Issue: #4847
Related issues
#4847