uint[1.111111E1111111111111] causes compiler to go into infinite loop #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were removed in solc 0.7.0, and now no longer reserved keywords. Signed-off-by: Sean Young <sean@mess.org>
LucasSte
requested changes
May 11, 2022
Signed-off-by: Sean Young <sean@mess.org>
seanyoung
force-pushed
the
szabo-finney
branch
2 times, most recently
from
46257a6
to
f2e3a09
Compare
LucasSte
requested changes
May 12, 2022
The lexer tries to calculate 10^1111111111111 which will be a very large number. This will take a long time. The lexer should not try to calculate numbers from strings, as this might fail and we do not want the lexer to give up, as no parsing and semantic analysis will be done. Signed-off-by: Sean Young <sean@mess.org>
LucasSte
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lexer tries to calculate 10^1111111111111 which will be a very large number. This will take a long time.
The lexer should not try to calculate numbers from strings, as this might fail and we do not want the lexer to give up, as no parsing and semantic analysis will be done.
Fixes #829