Skip to content

Commit

Permalink
Merge pull request #2086 from hypothesis/node-v14-puppeteer-workaround
Browse files Browse the repository at this point in the history
Work around issue with Node v14 and Puppeteer
  • Loading branch information
robertknight committed Apr 27, 2020
2 parents 7ac4f5a + 74253d1 commit 9ca6cf3
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion src/karma.config.js
Expand Up @@ -7,7 +7,15 @@ const envify = require('loose-envify/custom');
const glob = require('glob');

let chromeFlags = [];
process.env.CHROME_BIN = require('puppeteer').executablePath();

if (process.version.startsWith('v14.')) {
// See https://github.com/puppeteer/puppeteer/issues/5719
console.warn(
'Using system Chrome instead of Puppeteer due to issue with Node 14'
);
} else {
process.env.CHROME_BIN = require('puppeteer').executablePath();
}

// On Travis and in Docker, the tests run as root, so the sandbox must be
// disabled.
Expand Down

0 comments on commit 9ca6cf3

Please sign in to comment.