Change tests
option from --watch
to --live
to avoid node conflict
#317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 18.11 introduced a core
--watch
flag. This creates a conflict with using a--watch
option in thetests
task module. For now, change the name of the task's option to--live
to avoid this conflict.Updated usage:
gulp test --live
Testing this change
main
branch of theclient
, with a local node version of >=18.11, try runninggulp test --watch
. It should fail.frontend-build
. Runyalc publish
client
directory, runyalc add @hypothesis/frontend-build
client
, rungulp test --live
. It should work: tests should run and then run again on input/source file changes