Add User.deleted column to model code
#8710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanh
changed the title
User.deleted column to model code
seanh
commented
May 16, 2024
| @@ -25,7 +25,7 @@ SELECT | |||
| -- As we do our partial updates based on updated date, it's good if this | |||
| -- is actually high res timestamp, so we get less overlap | |||
| annotation.updated, | |||
| deleted, | |||
| annotation.deleted, | |||
There was a problem hiding this comment.
Need to make it unambiguous that this refers to annotation.deleted not user.deleted, otherwise Postgres chokes on the query
marcospri
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be used by the new incremental user delete service (#8700): deleting a user will immediately mark them as
User.deleted = Trueand then will incrementally delete all their data (and eventually the user row itself) in the backround. Users withdeleted = Truewon't be allowed to log in so that users can't be creating more data while we're incrementally deleting their account.Migration: #8711