Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-input-v1 support #1746

Closed
dragove opened this issue Mar 9, 2023 · 10 comments
Closed

Add text-input-v1 support #1746

dragove opened this issue Mar 9, 2023 · 10 comments
Labels
0: low prio Low priority - minor impact on usability enhancement New feature or request

Comments

@dragove
Copy link

dragove commented Mar 9, 2023

support text-input-v1 can help to make fcitx5 work in electron apps on native wayland.

support in kde is here: https://invent.kde.org/plasma/kwin/-/merge_requests/3403

@dragove dragove added the enhancement New feature or request label Mar 9, 2023
@vaxerski vaxerski added the 0: low prio Low priority - minor impact on usability label Mar 9, 2023
@vaxerski
Copy link
Member

vaxerski commented Mar 13, 2023

chromium patchset for TI3: https://chromium-review.googlesource.com/c/chromium/src/+/3220698

(this is just a ref)

@vaxerski
Copy link
Member

Do you have any other apps that use v1 other than chromium? For some weird reason chromium doesn't wanna send any events even though it binds properly. Maybe it also expects ime v1? tho that would be fucking weird.

@I-Want-ToBelieve
Copy link

I-Want-ToBelieve commented Mar 13, 2023

@vaxerski Did you pass the parameters that chromium needs?
--enable-features=UseOzonePlatform --ozone-platform=wayland
--enable-wayland-ime --gtk-version=4

@I-Want-ToBelieve
Copy link

I found something interesting. Fcitx5 running on hyprland can work in Microsoft’s edge browser.

@vaxerski
Copy link
Member

--gtk-version=4 forces TI3 instead of TI1 that I am implementing.

@vaxerski
Copy link
Member

oh. --enable-wayland-ime did it. Thanks.

@vaxerski
Copy link
Member

#1778 btw

@dragove
Copy link
Author

dragove commented Mar 14, 2023

I've tested #1778 with this app: https://github.com/Rocket1184/electron-netease-cloud-music and got the same result as q234rty tested. only electron 21 and above version works.
There is a bug that I can't delete my first charater in IME pre-edit region. And I also wonder why the pre-edit region has a yellow background.
btw, It also works on vscode if I use my system electron(22) to launch it. (Though there are some bugs if I don't use electron19 in vscode)

swappy-20230314-221047

I can't delete the last character a
swappy-20230314-221107

@vaxerski
Copy link
Member

Removing first character fixed in f960f72

regarding the yellow, idk. Should be ZWP_TEXT_INPUT_V1_PREEDIT_STYLE_NONE which should indicate no styling.

@vaxerski
Copy link
Member

I will close this as tiv1 is supported now, feel free to open issues for other bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0: low prio Low priority - minor impact on usability enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants