Fix preedit styling in chromium #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
ZWP_TEXT_INPUT_V1_PREEDIT_STYLE_NONEseems to be ignored in chromium, causing chromium to fallback on the yellow background mentioned in #1746 (comment), which unfortunately doesn't look great under dark themes.Change it to
ZWP_TEXT_INPUT_V1_PREEDIT_STYLE_HIGHLIGHTwhich causes chromium to draw a thick underline under the preedit.This PR also fixes the length of the preedit styling so the last character gets underlined as well.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Alternatives are:
ZWP_TEXT_INPUT_V1_PREEDIT_STYLE_DEFAULT, which in chromium means no styling at all and preedit text will look like regular text, which is not great IMO.ZWP_TEXT_INPUT_V1_PREEDIT_STYLE_UNDERLINE, which gives a thinner underline thanZWP_TEXT_INPUT_V1_PREEDIT_STYLE_HIGHLIGHTin chromium.Is it ready for merging, or does it need work?
Ready.