add decoration:dim_once
variable to dim only once during renderWindow (hyprwm#3617)
#3633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decoration:dim_once
variabledim_once
is set,renderWindow()
only dims if the current window is the same as the compositor's last windowDescribe your PR, what does it fix/add?
As described in #3617, the
dimaround
window rule's default behavior is to draw a new transparent rectangle for each open instance of the target application.This PR adds a
dim_once
variable indecorations
to allow the user to specify whether dimming should only be applied once instead of being compounded.At the moment, the
dim_once
variable is defaulted to false - which is the current dimming behavior. I'd recommend, though, that we default it to true. Dimming windows only once feels like the natural approach, or at least that's my opinion.Is it ready for merging, or does it need work?
Ready for merging.