Added toggleswallow dispatcher
#5548
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Apr 11, 2024
vaxerski
reviewed
Apr 12, 2024
| @@ -687,10 +688,16 @@ void Events::listener_unmapWindow(void* owner, void* data) { | |||
| g_pHyprOpenGL->makeWindowSnapshot(PWINDOW); | |||
|
|
|||
| // swallowing | |||
| if (PWINDOW->m_pSwallowed && g_pCompositor->windowExists(PWINDOW->m_pSwallowed)) { | |||
| if (PWINDOW->m_pSwallowed) { | |||
There was a problem hiding this comment.
what about previouslySwallowed? Also reset this :P
Generally I see no point in the "previously" member as the "swallowed" member shouldnt change anything. Just hide and unhide I'd say
There was a problem hiding this comment.
Replaced with a bool. Is there a better method to handle the hide and unhide in C++ ?
There was a problem hiding this comment.
why not check isHidden()? If swallowed != null and swallowed->ishidden(), it's swallowed, if it's not hidden, it's not
There was a problem hiding this comment.
I thought about this, but it could be hidden for other reasons, like if another window is fullscreen, no ?
There was a problem hiding this comment.
grouped windows are hidden
vaxerski
force-pushed
the
main
branch
9 times, most recently
from
7110a04
to
25aec3a
Compare
vaxerski
force-pushed
the
main
branch
2 times, most recently
from
fb471b8
to
1237732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
New feature:
toggleswallowdispatcher which allows to toggle the swallowed window with a keybind. Only if the window was originally swallowed will it work. Meaning that you can only "unswallow" and then "swallow" again a window, and so on.Useful when you want to have your terminal swallowed, but sometimes you also want to check the logs of your running application.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
Ready