use add_custom_command for generating protocols #6039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with build error in case of e.g.
$ rm protocols/*.{c,h}
$ cmake --build build
The workaround was to touch CMakeLists.txt. With this PR, protocol files
are properly regenerated with no extra efforts.
Also, resolve hyprwayland-scanner dependency via cmake instead of
pkg-config.
fufexan
reviewed
May 15, 2024
CMakeLists.txt
Outdated
| ) | ||
|
|
||
| find_package(hyprwayland-scanner 0.3.6 REQUIRED) |
There was a problem hiding this comment.
now we do anyways (see conflict)
There was a problem hiding this comment.
Right. @cnt0 can you update it?
There was a problem hiding this comment.
fixed & rebased
github seems to show false diffs in this PR, I have no idea why. CMakeLists.txt is the only file here that is actually changed compared to the main branch.
There was a problem hiding this comment.
Caused by merging main into your branch. A rebase should fix it. If it doesn't, git rebase --interactive HEAD~10 and delete any commits that aren't your own.
This fixes an issue with build error in case of e.g.
$ rm protocols/*.{c,h}
$ cmake --build build
The workaround was to touch CMakeLists.txt. With this PR, protocol files
are properly regenerated with no extra efforts.
Also, resolve hyprwayland-scanner dependency via cmake instead of
pkg-config.
…cmake-proper-rebuild
…cmake-proper-rebuild
* Stacked group tabs * Fix index when creating groupbar title textures * Changes for stacked dnd * formatting * Don't remove internal horizontal padding when calculating stacked bar width
modified: src/managers/SeatManager.cpp modified: src/managers/input/InputManager.cpp Co-authored-by: Agent_00Ming <agent00ming9366@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with build error in case of e.g.
$ rm protocols/*.h $ cmake --build buildThe workaround was to
With this PR, protocol files are properly regenerated with no extra efforts.
Also, resolve hyprwayland-scanner dependency via cmake instead of pkg-config.