[DYOD] Add variable string segment #2593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also create temp-directory when not exists
[skip ci]
Co-authored-by: Marie Fischer <marie.fischer@student.hpi.de> Co-authored-by: Clemens <68013019+clfesc@users.noreply.github.com>
…feature/variable-string-length-segment-three-layers
… github.com:phkeese/hyrise into feature/variable-string-length-segment-three-layers
… github.com:phkeese/hyrise into feature/variable-string-length-segment-three-layers
…eHeaders pipeline step
…string-length-segment-three-layers
Bouncner
reviewed
Dec 8, 2023
src/lib/storage/variable_string_dictionary/variable_string_dictionary_encoder.hpp
Show resolved
Hide resolved
src/lib/storage/variable_string_dictionary/variable_string_dictionary_encoder.hpp
Outdated
Show resolved
Hide resolved
src/lib/storage/variable_string_dictionary/variable_string_dictionary_encoder.hpp
Show resolved
Hide resolved
src/lib/storage/variable_string_dictionary/variable_string_dictionary_encoder.hpp
Show resolved
Hide resolved
| const AllTypeVariant& value) | ||
| const { | ||
| DebugAssert(!variant_is_null(value), "Null value passed."); | ||
| access_counter[SegmentAccessCounter::AccessType::Dictionary] += |
There was a problem hiding this comment.
Wondering if we should also increase other counters. We also search the offset_vector, right?
| /** | ||
| * @brief Segment implementing variable length string encoding. | ||
| * | ||
| * Uses vector compression schemes for its attribute vector. |
There was a problem hiding this comment.
As I haven't seen it yet (still reviewing): give a highlevel description of your implementation here?
| auto create_iterable_from_segment(const VariableStringDictionarySegment<T>& segment) { | ||
| #ifdef HYRISE_ERASE_VARIABLESTRINGDICTIONARY | ||
| PerformanceWarning("VariableStringDictionarySegmentIterable erased by compile-time setting"); | ||
| return AnySegmentIterable<T>(DictionarySegmentIterable<T, FixedStringVector>(segment)); |
There was a problem hiding this comment.
Looks like a copy paste error.
Bouncner
reviewed
Jan 9, 2024
Bouncner
reviewed
Jan 9, 2024
Bouncner
reviewed
Jan 9, 2024
Bouncner
force-pushed
the
feature/variable-string-length-segment-three-layers
branch
from
5d4719b
to
db0344f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds VariableStringSegment, a new segment for storing strings.
It works similarly to the FixedStringDictionarySegment by storing deduplicated strings in a contiguous block of memory.
It uses an additional layer of indirection to allow
VariableStringDictionarySegmentto behave like a dictionary, including optimized scan performance due tolower_bound()andupper_bound().Point access needs to go through another indirection, though.
Benchmarking
To run a benchmark, use the following command:
python3 scripts/evaluate_string_segments.py benchmark -b hyriseBenchmarkTPCH -b hyriseBenchmarkTPCDS -b hyriseBenchmarkJoinOrder -b hyriseBenchmarkStarSchema -d -e VariableStringDictionary -p cmake-build-release -s SCALE && python3 scripts/evaluate_string_segments.py benchmark -b hyriseBenchmarkTPCH -b hyriseBenchmarkTPCDS -b hyriseBenchmarkJoinOrder -b hyriseBenchmarkStarSchema -d -e VariableStringDictionary -p cmake-build-release -s SCALE --metricsRemember to replace
SCALEwith the intended scale factor.To create analysis diagrams from this, use the following command:
Performance
The other variable string segment branches are different approaches that did not perform well enough.
Update:
This is the most recent run with the final implement: