[DYOD] Support window function queries #2607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream said that we should create new `Chunk`s that re-use the previous segments (they are stored as shared pointers).
…nctionEvaluator::partition_and_sort()`
…dowFunction::Rank`
…pute_window_function`
Assigning does not work, because `operator[]` returns `AllTypeVariant`, not a reference.
It appears that someone is renaming our column after the operator has executed.
…it uses multiple partition-by columns
This is needed to prevent creating a chunk that has both `ReferenceSegment`s and `ValueSegments`s, as our output column is always represented by `ValueSegment`s.
We now reuse all segments from the input table. If the input table is a reference table, we create a new table with our output value segments and then add reference segments to this new table in our output table.
… Assert for correct rank frame
This adds `_templated_on_execute` so that the input column type and window function are compile time constants the whole time. This way, we don't get template instantiation errors down the line when we resolve types again.
niklasmohrin
force-pushed
the
window-functions-pr-head
branch
from
cbecb07
to
11288f3
Compare
…unequal orderings
Finn-HPI
force-pushed
the
window-functions-pr-head
branch
from
4be26c0
to
eaec7c1
Compare
…ng of private variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For intermediate review, see #2597. Additionally, we factored out the implementation of the parallel inplace merge sort into #2605.
nullptrchunkspartition_and_sort([DYOD] Add generic implementation of Parallel Inplace Merge Sort #2605)WindowFunctionExpressionPossible follow up work:
HashPartitionedDataonly have one vector and save offsets for hash buckets?)AllTypeVariantView?)Furthermore: Currently coverage says "warning: 100 functions have mismatched data"