Add Google Test discovery with ctest #2623
Open
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncner
reviewed
Oct 23, 2023
|
@mweisgut: Do we want to merge? |
mweisgut
approved these changes
Jan 8, 2024
|
@dey4ss : requesting you just in case you have a rough idea of cmake (which is not the case for me) and want to take a look here. If not, I'll go ahead and merge. |
|
Hey @nikriek, before I merge: I wanted to see the impact on my local machine and how often CMake is reconfigured when I add tests. Surprisingly (to me at least), there was no runtime overhead (I thought there is one given you use a timeout of 30s) and nothing happened when I added a new test to an existing test file (I expected to see CMake being triggered). Is that behaviour expected? Can I somehow see what the effect of this PR is (I don't use any IDE). |
|
Trying again to ping you, @nikriek. |
1 similar comment
|
Trying again to ping you, @nikriek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development with VSCode I found it helpful to see and run directly tests from the UI. This PR adds the required test discovery mechanisms for our unit and system tests.