[WIP] Dynamic task grouping #2639
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dey4ss
reviewed
Apr 26, 2024
src/lib/operators/aggregate_hash.cpp
Outdated
| @@ -45,7 +45,7 @@ using namespace hyrise; // NOLINT | |||
| // `get_or_add_result` is called once per row when iterating over a column that is to be aggregated. The row's `key` has | |||
| // been calculated as part of `_partition_by_groupby_keys`. We also pass in the `row_id` of that row. This row id is | |||
| // stored in `Results` so that we can later use it to reconstruct the values in the group-by columns. If the operator | |||
| // calculates multiple aggregate functions, we only need to perform this lookup as part of the first aggregate function. | |||
| // calculates multiple aggregate functions, we only need to perform this lookup as part of the first aggrete function. | |||
Bouncner
commented
May 6, 2024
| @@ -37,7 +37,7 @@ def is_setup(): | |||
|
|
|||
| # This file contains the IMDB dataset and is based on the specifications of the | |||
| # original JOB repository: https://github.com/gregrahn/join-order-benchmark | |||
| LOCATION = "https://bit.ly/hyriseimdbdataset" | |||
| LOCATION = "https://github.com/hyrise/hyrise/releases/download/imdb_data_set_v1.01/imdb_data.zip" | |||
| FILE_NAME = "imdb_data.zip" | |||
There was a problem hiding this comment.
I am currently in contact with Matthias to find an HPI-internal solution. But it probably won't make it into this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for now. The main change is to change the fixed number of groups to use and make it dynamic, depending on the current workload.