Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce Join Order Benchmark #41

Open
wants to merge 18 commits into
base: refactoring
Choose a base branch
from
Open

Reintroduce Join Order Benchmark #41

wants to merge 18 commits into from

Conversation

Bensk1
Copy link
Contributor

@Bensk1 Bensk1 commented Jun 26, 2020

No description provided.

@Bensk1 Bensk1 changed the base branch from master to refactoring June 26, 2020 14:21
@Bensk1 Bensk1 requested a review from marcelja July 15, 2020 16:41
klauck
klauck reviewed Jul 23, 2020
View reviewed changes
selection/query_generator.py

for column in self.columns:
if (
column.name in query_text_after_where
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not in query_text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the reasons was that column names before WHERE were not always clearly distinguishable. There are for example multiple tables with columns info.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment in the code to explain the parsing difficulties and that indexabale columns may be missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should probably do that or implement a more sophisticated parsing solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add a comment to the code and an issue requesting improvements.

klauck
klauck requested changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@klauck klauck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (except for minor change requests).

marcelja
marcelja approved these changes Jul 24, 2020
View reviewed changes
selection/table_generator.py Outdated Show resolved Hide resolved
selection/utils.py Show resolved Hide resolved
@Bensk1
Copy link
Contributor Author

Bensk1 commented Aug 10, 2020

I tried to address everything. Ready for merge from my side.

klauck
klauck requested changes Mar 21, 2021
View reviewed changes
Copy link
Collaborator

@klauck klauck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expect a comment for parsing indexable JOB columns, everything looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klauck klauck klauck requested changes

@marcelja marcelja marcelja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bensk1 @klauck @marcelja