change returnNull default to false

[adrai]

#1884

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[adrai]

Let's wait to merge this until you "verified" all ts changes.

[coveralls]

coverage: 92.14%. remained the same when pulling 8091302 on returnNull-false into 3c5308e on master.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mr-july]

@adrai: are you aware of the problem with the codeclima check?

[adrai]

@adrai: are you aware of the problem with the codeclima check?

@mr-july was not related to this PR

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[adrai]

@pedrodurek maybe there is something special to be done for this? https://github.com/i18next/i18next/pull/1885/files#diff-97e65d0ee521805ff4ac2d967b61062da8f5543569da4177ceeff689ce4463a3R129

[pedrodurek]

Hey @adrai, omitting null from the return type will only work when the resources type is not assigned (when devs opt not to have the keys inferred). Otherwise, it'll iterate over every key and extract the actual literal value. If you move the test to test/typescript/t.test.ts it should work.
If you prefer, we can also change the types for when the resources type is defined to fallback to string if the value is null, up to you!

[adrai]

returnNull false having a key value set to null behaves like a non-existing key... so i18next at runtime returns the defaultValue or the key name...

[adrai]

I've moved the test, like you suggested... I think it's ok to have an error when using typesafe translations... (behaves like non-existing keys)