Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1928: add fallbackNS type handling #1975

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

henrikvolmer
Copy link
Contributor

@henrikvolmer henrikvolmer commented Jun 19, 2023

PR adds the feature mentioned in #1928 to allow setting a custom type for fallback namespace.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

coveralls commented Jun 19, 2023

Coverage Status

coverage: 92.356%. remained the same when pulling ba68866 on henrikvolmer:feature/#1928 into d75c523 on i18next:master.

@adrai
Copy link
Member

adrai commented Jun 19, 2023

in theory fallbackNS can also be an array....

@adrai
Copy link
Member

adrai commented Jun 19, 2023

Do you think this could be extended to also support fallbackNS to be a string array?
If not, I'll merge anyway...

@henrikvolmer
Copy link
Contributor Author

Yes, will do it :)

@henrikvolmer
Copy link
Contributor Author

Done. Should work like that. :)

@adrai adrai merged commit b294499 into i18next:master Jun 19, 2023
5 checks passed
@adrai
Copy link
Member

adrai commented Jun 19, 2023

Awesome. Thank you.

@adrai
Copy link
Member

adrai commented Jun 19, 2023

included in v23.2.0

@adrai
Copy link
Member

adrai commented Jun 21, 2023

#1981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants