Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize logic for fallback ns #1984

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Optimize logic for fallback ns #1984

merged 1 commit into from
Jun 22, 2023

Conversation

pedrodurek
Copy link
Member

Optimizing the FallbackNs parsing process for easier understanding and maintainability.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@pedrodurek pedrodurek requested a review from adrai June 22, 2023 01:51
@coveralls
Copy link

Coverage Status

coverage: 92.356%. remained the same when pulling 33daec9 on pedrodurek:optimize-fallback-ns into 81d7604 on i18next:master.

@adrai adrai merged commit 387ba93 into i18next:master Jun 22, 2023
5 checks passed
@adrai
Copy link
Member

adrai commented Jun 22, 2023

thank you... ❤️
included in v23.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrai adrai Awaiting requested review from adrai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pedrodurek @coveralls @adrai