Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add contextSeparator also on v4 t types #2019

Merged

Conversation

marcalexiei
Copy link
Member

I just noticed there is a separate t type function file for typescript@4.
I added #2017 patch to that file.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@adrai adrai merged commit fb122fd into i18next:master Aug 9, 2023
4 of 5 checks passed
@coveralls
Copy link

Coverage Status

coverage: 92.36%. remained the same when pulling 6cab670 on marcalexiei:feature/type-custom-separator-on-ts4 into 181dcbd on i18next:master.

@adrai
Copy link
Member

adrai commented Aug 9, 2023

grazie ;-) => v23.4.4

@marcalexiei marcalexiei deleted the feature/type-custom-separator-on-ts4 branch August 9, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants