Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interpolation data to response if returnDetails is true #2053

Merged
merged 5 commits into from Oct 18, 2023
Merged

add interpolation data to response if returnDetails is true #2053

merged 5 commits into from Oct 18, 2023

Conversation

jedlikowski
Copy link
Contributor

Fixes #2046

What was changed?

  1. Added a new field (usedParams) to the object returned from t() when returnDetails = true. It should contain all the fields passed to interpolation.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

coveralls commented Oct 18, 2023

Coverage Status

coverage: 92.171% (-0.2%) from 92.37% when pulling 857b6f9 on jedlikowski:feature/add-interpolation-data-to-details-response into f6aea8d on i18next:master.

@adrai adrai merged commit c580d7a into i18next:master Oct 18, 2023
2 of 4 checks passed
@adrai
Copy link
Member

adrai commented Oct 18, 2023

included in v23.6.0
thank you for your contribution ;-)

@jedlikowski
Copy link
Contributor Author

@adrai Could you add hacktoberfest label to this PR so that it's picked up by my company's event dashboard? It recognizes PRs and repos labeled for hacktoberfest 😄

@adrai
Copy link
Member

adrai commented Oct 18, 2023

done ;-)

@jedlikowski
Copy link
Contributor Author

Thank you 👍 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

returnDetails should return parameters used to drive interpolation
3 participants