Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Welsh to languages #104

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Added Welsh to languages #104

merged 5 commits into from
Apr 29, 2024

Conversation

adamvindico
Copy link
Contributor

Added in Welsh

Purpose of PR

Adding in the Welsh language as instructed in proposal

PR Checklist

  • I have read the relevant readme.md file(s)
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Doesn't contain any sensitive information

Added in Welsh
Copy link

changeset-bot bot commented Apr 23, 2024

🦋 Changeset detected

Latest commit: 59c68bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@google-translate-select/constants Patch
@google-translate-select/theme-chalk Patch
@google-translate-select/react Patch
@google-translate-select/utils Patch
@google-translate-select/vue2 Patch
@google-translate-select/vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
google-translate-select-docs-9shf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 2:21am

@i7eo
Copy link
Owner

i7eo commented Apr 24, 2024

Added in Welsh

Purpose of PR

Adding in the Welsh language as instructed in proposal

PR Checklist

  • I have read the relevant readme.md file(s)
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Doesn't contain any sensitive information

If you want to add Welsh language to source code, you should do these:

  1. Add language code in GOOGLE_TRANSLATE_SELECT_LANGUAGES_CODES

  2. Add language info in GOOGLE_TRANSLATE_SELECT_LANGUAGES

  3. Add Welsh language class and style in https://github.com/i7eo/google-translate-select/blob/master/packages/theme-chalk/src/google-translate-select.scss#L82

That's all.

@adamvindico
Copy link
Contributor Author

Have made edits, thanks @i7eo

@adamvindico adamvindico changed the title Update props.ts Added Welsh to languages Apr 24, 2024
@i7eo i7eo merged commit 177e92a into i7eo:master Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants