Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUI example crashes when double-clicked #1062

Open
Vector-Hector opened this issue Feb 12, 2024 · 4 comments · May be fixed by #1063
Open

WebUI example crashes when double-clicked #1062

Vector-Hector opened this issue Feb 12, 2024 · 4 comments · May be fixed by #1063

Comments

@Vector-Hector
Copy link

Describe the bug
When double clicking the built WebUI example VST3 plugin, FL Studio will crash.

To Reproduce

  • Install the latest IPlug2 as described in the Getting Started
  • Build the IPlug2WebUI example
  • Make sure FL Studio finds the plugin
  • Add it to an FX slot
  • Make sure the plugin is currently closed
  • Double click the plugin

Expected behaviour
I expected it to just open and close very quickly.

IMPORTANT DETAILS

  • What plug-in format does it relate to - Currently only tested on VST3
  • What platform does it relate to - Currently only tested on Windows 11 with FL Studio 21
  • What IGRAPHICS_BACKEND does it relate to, IGRAPHICS_NANOVG, IGRAPHICS_SKIA or ALL? - Not sure, I am pretty new. If there is a default in the WebUI example, then that. But I can look it up if you tell me how to.

Additional context

  • This does not happen on non-WebUI examples as far as I have seen
  • It also happens if the index.html can't be found, like by setting an invalid path
@Vector-Hector
Copy link
Author

Adding this to the IWebView::OpenWebView callback of CreateCoreWebView2Controller fixed it for me:

if (mWebViewWnd == nullptr) {
  return S_OK;
}

@Vector-Hector
Copy link
Author

Not sure whether you accept pull requests / how you want them to be structured, so I won't do one.

@AlexHarker
Copy link
Collaborator

We do accept PRs - ideally after an issue, so please submit one - we wouldn't consider this complete until it was fixed in the main repo so I'm reopening this - I hope that's OK.

@AlexHarker AlexHarker reopened this Feb 15, 2024
Vector-Hector added a commit to Vector-Hector/iPlug2 that referenced this issue Feb 15, 2024
@Vector-Hector
fix double click crash
f27ef7c 
fixes iPlug2#1062
@Vector-Hector Vector-Hector linked a pull request Feb 15, 2024 that will close this issue
Open
@Vector-Hector
Copy link
Author

We do accept PRs - ideally after an issue, so please submit one - we wouldn't consider this complete until it was fixed in the main repo so I'm reopening this - I hope that's OK.

Alright, here it is: #1063

Vector-Hector added a commit to Vector-Hector/iPlug2 that referenced this issue May 24, 2024
@Vector-Hector
fix double click crash
a1ca04f 
fixes iPlug2#1062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix double click crash Vector-Hector/iPlug2
2 participants
@AlexHarker @Vector-Hector