Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1062
I am still new, so this is a bit of a pragmatic fix. As far as I understand the issue I was having, when opening the plugin in FL Studio, this loading code is executed. Buf if the plugin is closed very quickly, this callback seems to get called anyway. So without some kind of check whether the state is still valid, this function may run into problems. And the check I came up with was
I couldn't test this code on any machine except my dev machine (Windows 11, VST3, FL Studio 21), but I don't see how it could cause problems on other machines.
Hope it helps, love your library <3