Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double click crash #1063

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Vector-Hector
Copy link

fixes #1062

I am still new, so this is a bit of a pragmatic fix. As far as I understand the issue I was having, when opening the plugin in FL Studio, this loading code is executed. Buf if the plugin is closed very quickly, this callback seems to get called anyway. So without some kind of check whether the state is still valid, this function may run into problems. And the check I came up with was

if (mWebViewWnd == nullptr) {
  return S_OK;
}

I couldn't test this code on any machine except my dev machine (Windows 11, VST3, FL Studio 21), but I don't see how it could cause problems on other machines.

Hope it helps, love your library <3

@olilarkin
Copy link
Member

thanks for the PR... currently working on webview stuff and i'll have a look at this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebUI example crashes when double-clicked
2 participants