Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EditorConfig to reduce noise in commits due to whitespace changes #1007

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tristan00b
Copy link

@tristan00b tristan00b commented Oct 4, 2023

Addresses the config part of issue 1008 - Fixing whitespace violations

Changes:

  • .editorconfig
    • Preamble updated to reflect current usage
    • Simplified catch-all glob expression
    • Set insert_final_newline = true
    • Set end_of_line = crlf for Windows shell scripts
  • .gitattributes
    • Set rules for CMake and Powershell files to lf and crlf, respectively

Here are some instructions for a good PR

  • create an issue first to outline the problem, to reference in this PR
  • clearly describe the problem that the PR fixes
  • each PR should address one thing. It can include multiple commits, but you should try and tidy up work done into logical units if possible.
  • pay attention to iplug2 coding style
  • If it applies to an option e.g. IGRAPHICS_NANOVG or VST3 plug-ins, try to provide fixes for all options (e.g. all graphics backends or all plug-in formats)

If you follow these rules, it is more likely we will consider your PR, but please don't be upset if we decide we don't want to merge your work.

thanks, we like PRs!

oli & alex

Changes:
- Preamble updated to reflect its current usage
- Simplified catch-all glob expression
- Set 'insert_final_newline = true'
- set 'end_of_line = crlf' for Windows shell scripts
@tristan00b tristan00b marked this pull request as draft October 5, 2023 08:10
@tristan00b
Copy link
Author

tristan00b commented Oct 5, 2023

Changed my mind, I think I'd like to reformulate the issue, which is dealing with whitespace violations. I will create a formal issue and propose my solution.

Reopened after discussion in #1008.

@tristan00b tristan00b closed this Oct 5, 2023
@tristan00b tristan00b reopened this Oct 8, 2023
@tristan00b tristan00b marked this pull request as ready for review October 8, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant