Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up IPlugOSC #1010

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Clean up IPlugOSC #1010

wants to merge 2 commits into from

Conversation

olilarkin
Copy link
Member

The IPlugOSC classes are full of /** todo */ comments and expose a lot of private code. This PR goes some way to improving that, although more work can be done.

@AlexHarker
Copy link
Collaborator

There is still a static tmp WDL_HeapBuf involved, which looks likely to be an issue. Other than that all static variables (members and in methods) are gone except the one which is used to store a const set of characters (hdr[16]) which seems fine.


if (mIncomingEvents.GetSize())
{
static WDL_HeapBuf tmp;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the static in question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants