Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App/separate settings dialog #1043

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

AlexHarker
Copy link
Collaborator

@AlexHarker AlexHarker commented Jan 1, 2024

This is work on the desktop Standalone App Audio IO

It is based on https://github.com/iPlug2/iPlug2/tree/app/flexible-io

The work is the following:

  • iPlugAPP clean-up and spacing changes
  • RTAudio update to 6.0.1 (and changes to fix builds with this version)
  • Splitting of the settings dialog into a separate file/class in a way that allows different approaches to this window (last commit only)

Notes:

  • No channel flexibility/settings dialog interaction changes are yet implemented
  • -1 is not used as a special value for audio device IDs as RTAudio does not guarantee what values IDs might take. ValidatedID is used where it is needed to indicate if the ID is empty
  • Renaming has been used to clarify class members and types (e.g. State -> Settings)
  • IPlugAppDialog is included in IPlugAppHost by composition and various methods have been made private to more fully separate the settings dialog from the host
  • MainDlgProc is in the host file, but the settings dialog has its own DlgProc
  • None of the changes thus far change the operation of the settings dialog or the format of the saved data. Merging should not break any functionality.

@olilarkin
Copy link
Member

Gave it a quick look through and compiled, looks good so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants