Ios/midi io

[olilarkin]

Here are some instructions for a good PR

• create an issue first to outline the problem, to reference in this PR
• clearly describe the problem that the PR fixes
• each PR should address one thing. It can include multiple commits, but you should try and tidy up work done into logical units if possible.
• pay attention to iplug2 coding style
• If it applies to an option e.g. IGRAPHICS_NANOVG or VST3 plug-ins, try to provide fixes for all options (e.g. all graphics backends or all plug-in formats)

If you follow these rules, it is more likely we will consider your PR, but please don't be upset if we decide we don't want to merge your work.

thanks, we like PRs!

oli & alex

[olilarkin]

Storing a pointer to the WDL_String here and setting the value in the notification handler feels wrong here... trying to think of other options @AlexHarker

[AlexHarker]

Yes - I can see why that's not ideal, but we are picking it up at the other end and the idea was to be able to get the value out here - I wouldn't want to pass a pointer to an plugin-developer in this way, but here the framework is using the notification system to pass around data. As far as I am aware (and I am pretty sure I would have tested before using this approach) the notification system is immediate and synchronous, so it should be safe - it's just that the notification system is the best way to communicate between app and plugin (given that the framework has no notion of the wrapping app). This was based on the BT Midi notification stuff - if there's a better way or a way that involves putting a hook in the plugin base etc. then I'd be ok with that.