mac-opengl render: proper init and exit (fixes issue #1080) #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clearCurrentContext solves issue #1080. It is also apparently an accepted solution to various mac+opengl issues on SO, for example:
https://stackoverflow.com/questions/21798018/nsopenglcontext-destroying-textures-of-another-context
Most UI repos out there seem to start render calls with makeCurrentContext and end with clearCurrentContext. That is what I had to go on since Apple's docs don't say why/when it should be used.
The addObserver solves an issue in FL Studio-mac where if a complex iPlug2 gui is opened and closed really quickly, it would crash the FL Studio renderer. Same here, no docs do go on, but it looks like something people have learned is good to do.