Add basic legato support to MidiSynth and VoiceAllocator #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hmm... the build errors are |
|
Damn, spent a long time messing around trying to get SKia working on Win
CI. I’ll just patch skia, since we need to do that anyway in order to build
it
…On Fri, 15 Oct 2021 at 08:01, asedev ***@***.***> wrote:
Sounds like this issue:
https://iplug2.discourse.group/t/vs-2019-update-16-11-10-aug-2021-breaks-build-with-igraphics-skia
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#786 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFACLS4WCARBIUF7NV5PI3UG67RZANCNFSM5FHKLK3Q>
.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@olilarkin - as this is now completing tests are you happy to merge? |
|
I wasn't able to test it yet, so not yet |
|
Friendly nudge :) |
|
sorry i will try and look at this soon @mmontag |
olilarkin
force-pushed
the
master
branch
2 times, most recently
from
ed4d21e
to
e029826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a basic legato support in MidiSynth.
The VoiceAllocator will not retrig voices when legato is enabled. This only affects kPolyModeMono.