Apply Clang Format #943
Apply Clang Format #943
Conversation
|
Do we really want:
rather than setting this to zero (which would match the previous style?). I can live with it, but it's not my preference |
|
Do we want to format 3rd party things like iPlug/Extras/HIIR/*? |
| IVStyle newStyle = *this; | ||
| newStyle.showLabel = show; | ||
| return newStyle; | ||
| } |
There was a problem hiding this comment.
This is an issue, because it hasn't added a blank line when expanding these helper functions onto different lines
There was a problem hiding this comment.
yeah i couldn't work out what rule would influence that. Fixed up manually
|
If I run clang format locally I get different results in relation to trailing comments. what version of clang format are you on (and are we working towards)? I believe that at least some of this is to do with AlignTrailingComments post clang format 16 (see docs). It is important to fix that as otherwise I can't easily test other changes. I am on version 16. |
I'll remove it. I want to update HIIR and move it to Dependencies |
yep... i had an old clang format, going to push updates... |
olilarkin
force-pushed
the
clang-format
branch
2 times, most recently
from
3e6e052
to
b454a34
Compare
Tweak some rules and use git ls-files to only modify tracked files
olilarkin
force-pushed
the
master
branch
2 times, most recently
from
ed4d21e
to
e029826
Compare
This PR applies clang-format to the IPlug2 codebase