Skip to content

Commit

Permalink
tools: don’t emit illegal utf-8 from icutrim/iculslocs
Browse files Browse the repository at this point in the history
- argv[0] was being emitted into a utf-8 stream, but argv[0] may
not be legal utf-8
- fix by not emitting argv[0] (was only for a source comment)
- partially resolves nodejs#17077

PR-URL: nodejs#19756
Fixes: nodejs#17077
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
srl295 committed Apr 3, 2018
1 parent 1a5a19d commit a820f41
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tools/icu/iculslocs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,9 @@ int list(const char* toBundle) {
if (bf != NULL) { // NOLINT (readability/null_usage)
// write the HEADER
fprintf(bf,
"// Warning this file is automatically generated\n"
"// Updated by %s based on %s:%s.txt\n",
PROG,
"// NOTE: This file was generated during the build process.\n"
"// Generator: tools/icu/iculslocs.cc\n"
"// Input package-tree/item: %s/%s.res\n",
packageName.data(),
locale);
fprintf(bf,
Expand Down

0 comments on commit a820f41

Please sign in to comment.