Support non base64 data:image/svg+xml icons. #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerardasB
approved these changes
Oct 17, 2023
|
@Mergifyio backport release/4.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
(cherry picked from commit 07d13e9)
raplemie
added a commit
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update IconWebComponent to also support svg data uri that are not base64 encoded, this is what the default esbuild dataurl is exporting. We are still doing the same sanitization we used to do for base64 data.
Testing
Issue
resolves #421
helps for #521