Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move node-cli to be pure ESM, use Conf for persistent storage #203

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
67e1402
Migrate from node-keytar to crypto
hl662 Aug 18, 2023
3a739b4
add option to configure refresh token storage path
hl662 Aug 21, 2023
c3577ce
move @types/node-persist to devDep
hl662 Aug 21, 2023
d3f9ea9
update pnpm-lock
hl662 Aug 21, 2023
f29e56b
rush change
hl662 Aug 21, 2023
81edc40
Apply suggestions from code review
hl662 Aug 21, 2023
3690ccb
delete cached entry when scopes are different
hl662 Aug 21, 2023
4d3339a
Merge branch 'nam/node-cli-keytar' of github.com:iTwin/auth-clients i…
hl662 Aug 21, 2023
13d7cde
resolve merge conflicts
hl662 Aug 22, 2023
1f1f120
Merge branch 'main' into nam/node-cli-keytar
hl662 Aug 22, 2023
a98f439
Change files
hl662 Aug 22, 2023
b3114a9
remove previous rush change file
hl662 Aug 22, 2023
2e462ee
move from cjs to esm
hl662 Aug 22, 2023
f9f9f6d
Merge branch 'nam/node-cli-keytar' into nam/esm-conf
hl662 Aug 22, 2023
7dce78b
use Conf in node-cli esm
hl662 Aug 22, 2023
17f9e6c
add main field in package.json, fix config path for token store
hl662 Aug 23, 2023
da4ba81
move from cjs to esm
hl662 Aug 22, 2023
77aba02
Migrate from node-keytar to crypto
hl662 Aug 18, 2023
35dd5ff
add option to configure refresh token storage path
hl662 Aug 21, 2023
8a7aae6
move @types/node-persist to devDep
hl662 Aug 21, 2023
2519feb
rush change
hl662 Aug 21, 2023
fdefb4d
delete cached entry when scopes are different
hl662 Aug 21, 2023
3d2c41e
Apply suggestions from code review
hl662 Aug 21, 2023
0cba13f
resolve merge conflicts
hl662 Aug 22, 2023
45a1ac1
remove previous rush change file
hl662 Aug 22, 2023
04640d5
use Conf in node-cli esm
hl662 Aug 22, 2023
aff3dae
add main field in package.json, fix config path for token store
hl662 Aug 23, 2023
5289bb3
Merge branch 'nam/esm-conf' of github.com:iTwin/auth-clients into nam…
hl662 Aug 23, 2023
e531e3e
add interface definition for object stored
hl662 Aug 23, 2023
e6e1c4f
Change files
hl662 Aug 23, 2023
f6b9dc4
revert mocha config spec change
hl662 Aug 23, 2023
aadfada
remove mix of import and require in statements
hl662 Aug 23, 2023
5bcda63
use nodenext in tsconfig, use 4.x in core deps
hl662 Aug 23, 2023
c33fc77
bump itwin build tools off of dev
hl662 Aug 23, 2023
0d2c008
fix indent
hl662 Aug 23, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 5 additions & 6 deletions packages/node-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "module",
"description": "Node.js command-line authorization client for iTwin platform",
"engines": {
"node": ">=16"
"node": ">=18"
},
"scripts": {
"build": "npm run -s build:esm",
Expand All @@ -19,9 +19,8 @@
"pack": "npm pack",
"rebuild": "npm run clean && npm run build"
},
"main": "./lib/esm/index.js",
"exports": "./lib/esm/index.js",
"typings": "./lib/esm/index.d.ts",
"typings": "./lib/esm/index.d.ts",
aruniverse marked this conversation as resolved.
Show resolved Hide resolved
"author": {
"name": "Bentley Systems, Inc.",
"url": "http://www.bentley.com"
Expand All @@ -33,15 +32,15 @@
"directory": "packages/node-cli"
},
"dependencies": {
"@itwin/core-common": "^3.3.0 || ^4.0.0",
"@itwin/core-common": "^4.0.0",
"@openid/appauth": "^1.3.1",
"conf": "^11.0.2",
"open": "^8.3.0",
"username": "^5.1.0"
},
"devDependencies": {
"@itwin/build-tools": "^4.0.0-dev.93",
aruniverse marked this conversation as resolved.
Show resolved Hide resolved
"@itwin/core-bentley": "^3.7.0",
"@itwin/core-bentley": "^4.0.0",
"@itwin/eslint-plugin": "^3.7.0",
"@types/chai-as-promised": "^7.1.1",
"@types/chai": "^4.2.22",
Expand All @@ -60,7 +59,7 @@
"typescript": "~5.0.2"
},
"peerDependencies": {
"@itwin/core-bentley": "^3.3.0 || ^4.0.0"
"@itwin/core-bentley": "^4.0.0"
},
"eslintConfig": {
"plugins": [
Expand Down
4 changes: 2 additions & 2 deletions packages/node-cli/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"extends": "./node_modules/@itwin/build-tools/tsconfig-base.json",
"compilerOptions": {
"target": "ES2022",
"module": "Node16",
"moduleResolution": "Node16",
"module": "NodeNext",
"moduleResolution": "NodeNext",
"outDir": "./lib"
},
"include": [
Expand Down
22 changes: 18 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.